Per-session kore-rpc server state
#3702
Conversation
goodlyrottenapple
requested review from
jberthold and
geo2a
and removed request for
jberthold
|
The ability to share modules between clients in a controlled way can be very useful, I'd prefer a solution that enables that. Did you consider the proposal under runtimeverification/hs-backend-booster#383 (comment)? |
Is this due to performance? Do you expect these modules to be very big?
I was working under the assumption that we simply want to avoid module clashes and tweaking the global state to only be a session state seemed like a much simpler solution. Using IDs and especially importing modules via IDs whilst maintaining module names completely disjoint from said IDs seemed a much more substantial change to both back-ends. |
No, it's for ease of programming against the API.
Implementation effort should of course be taken into consideration. Can you post your feedback on the design issue so that we can iterate on it? |
In order to use the
kore-rpcserver concurrently in a safe way, we modify the server to create a new server state per each session. This way, each client will get the same initial server state and calls to add-module will always be safe, because the added modules are per session and not shared between different clients. This of course means that each client has to send the required modules to the server separately.Part of runtimeverification/hs-backend-booster#383